Precision Landing Mavlink message

anon67614380 · July 18, 2018, 4:13pm

Hello, any chance we will get some Mav message for “target aquired” during precision landing in 3.6.x??

Thanks,

Corrado

rmackay9 · July 19, 2018, 4:16am

It’s probably best to add this as an enhancement request in the issues list so it isn’t forgotten. I can’t personally make any promises, I’m mostly focused on getting the critical bugs fixed in 3.6… perhaps another developer will pick it up though.

Eosbandi · July 19, 2018, 12:51pm

Willing to look into it, since i need the same functionality. Where to create the Pull request ? Against 3.6 or master branch ?

anon67614380 · July 19, 2018, 1:48pm

Hello Andras, glad you are interested in it too. If you need any testing, we have 2 machines with IR-Lock intalled and perfectly working.

regards,

Corrado

rmackay9 · July 20, 2018, 2:16am

Andras,

Thanks for stepping up! PRs should definitely go against master and then if there’s still time to fit it into Copter-3.6 we would merge it over to the Copter-3.6 branch.

Eosbandi · July 22, 2018, 7:19pm

Pull request created : https://github.com/ArduPilot/ardupilot/pull/8985
Hope it is OK. Tested in SITL and on my quad.

anon67614380 · July 23, 2018, 7:02am

Thank you!!! This is great!!

Does it need to be implemented in Mission Planner or the category of warnings it belongs to authomatically shows up on MP hud?

regards,

Corrado

Eosbandi · July 23, 2018, 7:26am

No changes needed in MP, warnings are displayed automatically.

anon67614380 · July 23, 2018, 7:32am

That is really great, looking forward to test it, hope it’ll make it in the next rc release.

regards,

Corrado

anon67614380 · August 6, 2018, 8:30am

Hello Andras, have been following your github pull request, any news on it? Think it’ll make on the next RC release?

Looking forward to test it.

Corrado

Eosbandi · August 6, 2018, 1:38pm

I’m waiting for a word from @rmackay9 about the correctness of the implementation.

anon67614380 · August 6, 2018, 3:12pm

Great, thanks.

Corrado

fnoop · August 6, 2018, 4:40pm

Hey guys, here’s an alternative implementation:

This uses structured mavlink message instead of a GCS text message as part of EXTRA3 stream group. Not better or worse, just different

Eosbandi · August 6, 2018, 6:04pm

Nice, the only drawback that it needs modification at the GCS side as well to interpret and display the message. However ultimately I think this is the right way to do it.

anon67614380 · August 6, 2018, 7:36pm

Is this in master already?

fnoop · August 6, 2018, 8:43pm

Hi @anon67614380 if you’re referring to mine then no, I’ve only just raised a PR. I’ve made some related PRs as well including a similar one to improve logging, you can follow progress here:
https://discuss.ardupilot.org/t/ac-precland-improvements-and-updates/31614

anon67614380 · August 6, 2018, 8:44pm

Thank you for your work, will follow closely.

Corrado