Dev Call Nov 20, 2023

Issues & Pull Requests

discuss VTOL landing ANYWHERE while in guided mode

Plane

Copter

Attendee count (max): 16

UTC2300 - AP_BattMonitor:remove unused param from analog fuel level by Hwurzburg · Pull Request #25584 · ArduPilot/ardupilot · GitHub

  • Remove unused parameter from fuel level
  • Merged!

UTC2302 - AP_MSP: update option metadata for clarity by Hwurzburg · Pull Request #25580 · ArduPilot/ardupilot · GitHub

  • Fix up some documentation around MSP parameters
  • Merged!
  • The “unused” should probably not appear in the GUIs, so we might want to remove that in the future

UTC2306 generators: js: fix sinon dependency to 15.2.0, add node tests by Williangalvani · Pull Request #875 · ArduPilot/pymavlink · GitHub

  • Improved javascript support in pymavlink
  • Merged!

UTC2308 - common.xml: add extensions to MANUAL_CONTROL by Williangalvani · Pull Request #338 · ArduPilot/mavlink · GitHub

  • Updating to Upstream to implement button presses in Sub
  • Merged

UTC2311 - https://github.com/ArduPilot/ardupilot/pull/24411

  • PID notches and D feed-forward
  • Come back to this when we have a tridge

UTC2311 - AP_Scripting: change some _INFO msgs to _CRITICAL by magicrub · Pull Request #25081 · ArduPilot/ardupilot · GitHub

  • Elevate some info messages to critical
  • Will merge once one of them has been changed to warning

UTC2318 - Plane: Mode LoiterAltQLand to reuse same loiter point if available by magicrub · Pull Request #25318 · ArduPilot/ardupilot · GitHub

  • Reuse same loiter point when entering loiteraltqland
  • Need to test a whole bunch of places here, not just loiteraltqland
    • Validity checks should be in mode, says Pete
  • Tom will change things to not change behaviour and do it as PH wants
    • PH will then approve….

UTC2321 - GCS: Change param default SRx_PARAMS to 50 by magicrub · Pull Request #25365 · ArduPilot/ardupilot · GitHub

  • Change param default streamrates
  • This could break a lot of people’s setups
  • Should we document this better in the Wiki?
  • Maybe change the defaults in the ground control stations?
  • Closed

UTC2330 - Fix C++ One Definition Rule violations and misc. UB by tpwrules · Pull Request #25394 · ArduPilot/ardupilot · GitHub

  • Fix C++ one-definition rule violations and misc
  • Separate PR for the sample_regs
  • We’ll move to using a hal_mutable reference rather than the mutable keyword
  • Will also have a separate PR for the array of uarts
  • Tpw_rules will raise more PRs and bring them up on the relevant Discord channel

UTC2337 GCS_MAVLink: Tidy defines in try_send_message by peterbarker · Pull Request #25485 · ArduPilot/ardupilot · GitHub

  • Tidy use of defines in try_send_message
  • MergeOnCIPass

UTC2343 - Plane: Allow BATT_WATT_LIMIT to bring Throttle to 0% and report it by magicrub · Pull Request #25502 · ArduPilot/ardupilot · GitHub

  • Allow BATT_WATT_LIMIT to bring throttle to 0% and report it
  • Makes a bug worse according to PH
  • If there is a catastrophic failure on an ESC
    • Does a hard-failure
    • And your battery voltage drops and you potentially brown out
    • Then catch that problem
    • Drop your throttle
    • If you go down to 25% then you will run out
    • So go to zero
    • So you can reboot the aircraft
  • Tom saw a mechanical failure where a motor would not turn
  • 25% is an arbitrary number
  • Parameterise the lower threshold?
  • PH and Tom spotted pre-existing bug
    • uses wrong throttle
    • Takes input throttle
    • You end up having an i-term watt limit to zero
    • Happens when you set a very slow throttle slew rate
  • PH says WATT_LIMIT is a bit of an unknown quantity
    • Thinks adding a parameter is the correct thing
  • Will come back to this next week
  • Another feature which only works on the first battery…
  • Tom will create a separate PR for the new define

UTC2354 - AP_DDS: MicroROS agent doesn't publish topics when GPS automatically gets GPS lock. · Issue #25535 · ArduPilot/ardupilot · GitHub

  • MicroROS agent doesn’t public topics when GPS automatically gets GPS lock
  • This might just be confusion between serial0, serial1 and USB

UTC2358 - SIM_GPS_GSOF - support dcol parser via new bidirectional data parsing by Ryanf55 · Pull Request #25541 · ArduPilot/ardupilot · GitHub

  • New bidirectional data parsing in simulated GSOF
  • Several comments left in

UTC0008 - Plane: add param LAND_RNGFND_HLD to hold-off lidar during landing by magicrub · Pull Request #25549 · ArduPilot/ardupilot · GitHub

  • Add param to hold off using lidar during landing
  • Peter’s concern is that this is part of a mission
    • Tom points out the abort altitude takes up the storage we have
  • Could be done with scripting
  • PH thinks the logic should be in AP_Landing
    • …pass the rangefinder correction in?
  • Applied to both slope and deep-stall
  • Applying it in flaring always is interesting….
    • What’s it supposed to do once it has flared?
    • What’s the result?
    • Do it more intelligently if things were in AP_Landing
    • This is why things should be in AP_Landing rather than in Plane
  • Tom will put it into AP_Landing and from there into Slope, possibly

UTC0024 - AP_RangeFinder Add signal_quality_pct to range finder state by ptrmu · Pull Request #25550 · ArduPilot/ardupilot · GitHub

  • SIGNAL_QUALITY_UNKNOWN is better than NODATA
  • Several other small things

UTC0032 - GCS_MAVLink: exclude deadlock-creation based on FAILURE_CREATION_ENABLED by peterbarker · Pull Request #25555 · ArduPilot/ardupilot · GitHub

  • Put more code behind AP_MAVLINK_FAILURE_CREATION_ENABLED
  • Merged!

UTC0035 - SITL: Bump up read rate on SITL by Ryanf55 · Pull Request #25559 · ArduPilot/ardupilot · GitHub

  • Bump up read rate on SITL simulated GPS drivers
  • Peter will merge after some very minor changes

UTC0048 - Copter/Rover-4.4.0 issues list · Issue #23192 · ArduPilot/ardupilot · GitHub

  • 4.4.3 went out
    • With M10 fix in
  • 4.4 is very stable these days and nobody disagreed on the call
  • Randy’s been going back through the issues list
    • Mavftp speed
    • 30MB file takes a long time
      • We found why it was slow
        • Optimised for download, not upload
        • Enhancement request
          • Clients will need to be updated to do pipelining
            • Will do it in MAVProxy and then do it in MissionPlanner
          • No burst upload in protocol
  • Randy’s worked out why boats overshoot waypoints
    • 4.4 for Rover someday!

UTC0052 - Copter/Rover-4.4.0 issues list · Issue #23192 · ArduPilot/ardupilot · GitHub

  • Microstrain 7 initial support
  • Tridge is working on support for another AHRS, reserve a different ID (4 rather than 3)
  • Sim will come later. It requires refactor and Ryan preferred doing that in a different PR
  • Tridge said the GPS replay won’t work for AHRS yet, but it should be moved
  • Tridge said we should use 5Hz GPS data by default rather than 1Hz.
  • Distinguishing between raw sensor data and fusion output is problematic
    • It’s currently handled
  • Few issues, Ryan will mention it in code review when it’s been looked at again

UTC0105 - DroneCAN: support CAN serial ports by tridge · Pull Request #25577 · ArduPilot/ardupilot · GitHub

  • Serial over CAN - new-style
  • Use a periph’s serial ports as if they were directly off the autopilot
  • Tested in flight with GPS
  • Can update firmware on serial GPS connected to periph connected to autopilot via CAN connected to GCS via mavlink…
  • Tridge wants a periph node with multiple serial ports that also have flow control

UTC0107 - Plane: stable 4.4.x issues list · Issue #15941 · ArduPilot/ardupilot · GitHub

  • Plane update
  • Bad firmware from Hobbywing
  • We have a workaround merged to master
  • Will go out in 4.4 if another goes out
  • Tridge is trying to convince them to send out a new firmware
  • Updating firmware currently requires a special adapter….

UTC0131 - Close

1 Like