Dev call July 29, 2024

issues & Pull Requests

Plane

Copter

Discord is having server issues and I may not be able to discuss my PR until they revert the bad patch. I will try and join the devcall later to do so.

Attendee count (max): 15

UTC2301 - Backport: AP_NavEKF2: Fix 3-axis mag fusion per axis error handling by JustCurious8 · Pull Request #21966 · ArduPilot/ardupilot · GitHub

  • Merging fixes into old branches
  • Older branches are useless without fixes to compilation
  • We can and should patch older releases with things like this
  • Tridge supplied patch in Discord chat
  • This one can be closed with a we-fixed-it-like-this thing

UTC2306 - GCS_MAVLink: Add FLIGHT_INFORMATION message by nexton-winjeel · Pull Request #25489 · ArduPilot/ardupilot · GitHub

  • Add FLIGHT_INFORMATION message
  • Should it be on all boards?
  • Needs patches to build_options and extract_features.py
  • Turn off on the smaller boards
  • Perfectly reasonable request - can be merged afterwards

UTC2314 - Copter: Make multiple decisions into a SWITCH statement by muramura · Pull Request #26902 · ArduPilot/ardupilot · GitHub

  • Convert if to case
  • Merged!

UTC2316 - Rover: Notify lat and long to the seventh decimal place by muramura · Pull Request #27020 · ArduPilot/ardupilot · GitHub

  • We won’t get cm
  • Randy would like all seven digits
  • Randy would like a print-lat-lng function
  • Allocation?
  • %F for print-as-double
    • Gcc won’t give warnings

UTC2330 - Copter: Handle DO_MOUNT_CONTROL yaw angle as body frame by nexton-winjeel · Pull Request #27071 · ArduPilot/ardupilot · GitHub

  • Handle DO_MOUNT_CONTROL yaw angle as body frame
  • Randy will do some testing
  • Roll over tilt, no pan
    • Needs to rotate the vehicle
  • Should probably remove this in favour of new gimbal control stuff

UTC2332 - AP_Scripting: Adds I2C transfer() bindings and an example by IanBurwell · Pull Request #27287 · ArduPilot/ardupilot · GitHub

  • I2c transfer bindings and an example
  • Changing run_command_int from bool to MAV_RESULT
    • Nothing out there was checking the return
  • Merged!

UTC2340 - Plane: Change IF statement to SWITCH statement by muramura · Pull Request #27366 · ArduPilot/ardupilot · GitHub

  • Convert case to switch
  • Could have been done when we were refactoring that code, but no testing data was provided in this PR
  • Not worth the risk of introducing a bug
  • Closed

UTC2342 - AP_DroneCAN: fix and clean up DNA server by tpwrules · Pull Request #27543 · ArduPilot/ardupilot · GitHub

  • Fix and clean up DNA server
  • Corrects preservation of IDs
  • Fixes many bugs
  • No tests for this stuff in autotest?
    • Quadplane CAN frames are tested
    • But you get the same ID you previously had
  • Locking fix still coming
    • Probably only an issue on Linux due to threading

UTC2345 - board_types.txt: Reserving board IDs for Easy Aerial by rishabsingh3003 · Pull Request #27623 · ArduPilot/ardupilot · GitHub

  • New policy, only 10-at-a-time
  • Peter will force-push
  • And a comment

UTC2351 - AP_Scripting: reduce flash usage by tpwrules · Pull Request #27630 · ArduPilot/ardupilot · GitHub

  • Optimisations to reduce flash usage in LUA
  • No real downsides
  • Code optimisations to use less flash
  • Remove redundant parameters and function calls
  • Aerobatics on SimOnHardware is a good stress test

UTC2355 - Make chibios_hwdef.py include error clearer by peterbarker · Pull Request #27633 · ArduPilot/ardupilot · GitHub

  • Make include error clearer
  • Merged!

UTC2357 - Plane: move `have_autoenabled_fences` to be private in `ModeTakeoff` by IamPete1 · Pull Request #27638 · ArduPilot/ardupilot · GitHub

  • Make have_autoenabled a private variable
  • Mysteriously larger
  • Merged!

UTC2359 - Plane: option to allow plane to crosstrack on all mission items by timtuxworth · Pull Request #27639 · ArduPilot/ardupilot · GitHub

  • Option to allow plane to crosstrack
  • Crosstracking gets disabled after first mission item?!
    • Add mission option bit to always use crosstracking
  • Cross-tracks from where you restart the mission
    • There’s a test in navigation.cpp which says if you’re within a radius of your waypoint it would crosstrack
  • Prev_wp is probably what’s going on
  • User wants to come back on-line as soon as possible
  • Rover has an option bit to turn this behaviour on
  • Explicitly have a set_xtrack to set start of track
    • Allows script to decide whether to crosstrack or not
  • Any mode change wer replace the prev_wp
    • So if you come into auto it has already obliterated prev_wp
  • Get_crosstrack_start_loc returns nil if no crosstrack
  • When starting avoidance, grab current crosstrack start

UTC0018 - AC_AutoTune: make axis-type enum-class by peterbarker · Pull Request #27642 · ArduPilot/ardupilot · GitHub

  • Use an enum-class AxisType instead of defines
  • Merged!

UTC0020 - Copter: add a Mode method to disable crash check by peterbarker · Pull Request #27643 · ArduPilot/ardupilot · GitHub

  • Add a method onb mode to allow a mode to disable crash checking
  • Merged!
  • Follow-up PR to remove units from scalar documentation

UTC0023 - RC_Channel: Express option numbers in bits by muramura · Pull Request #19230 · ArduPilot/ardupilot · GitHub

  • Rework duplicate-rc-options sanity check
  • Edge-triggered
    • Should we allow duplicate options?
  • Merged!

UTC0027 - add build option to not send RC_CHANNELS_RAW by peterbarker · Pull Request #27645 · ArduPilot/ardupilot · GitHub

  • Add option to disable RC_CHANNELS_RAW
  • Merged!

UTC0029 - Copter: correct skyviper-v2450 compilation by peterbarker · Pull Request #27647 · ArduPilot/ardupilot · GitHub

  • Fix skyviper compilation
  • Merged!

UTC0030 - AP_Scripting: fix failures with require() by tpwrules · Pull Request #27652 · ArduPilot/ardupilot · GitHub

  • LUA: Fix failures with require call
  • Adds a regression test
  • Merged!

UTC0033 - https://github.com/ArduPilot/ardupilot/pull/27655

  • Use enum-class for PWMType
  • Problems with blheli
  • Thomas linked the Periph code
  • Should thie define go into the HAL rcoutput library?
  • There’s a ChibiOS equivalent of this as well!
  • Peter will negotiatye with Andy to get this one in

UTC0039 - hwdef: remove MatekL431-Periph by peterbarker · Pull Request #27659 · ArduPilot/ardupilot · GitHub

  • Remove MatekL431-Periph
  • Remove GPS instead?
  • Closed it

UTC0052 - Replace HAL_NO_MONITOR_THREAD with HAL_MONITOR_THREAD_ENABLED by peterbarker · Pull Request #27661 · ArduPilot/ardupilot · GitHub

  • Change from HAL_NO_MONITOR_THREAD to HAL_MONITOR_THREAD_ENABLED
  • Merged!

UTC0052 - AP_Scripting: adjust string metatable setup to fix sandbox integrity by tpwrules · Pull Request #27666 · ArduPilot/ardupilot · GitHub

  • Adjust string metatable set upto fix sandbox integrity
  • Deleting methods could affect other scripts
  • Merged!

UTC0054 - AP_BattMonitor: ESC: integrate consumed mah if not provided by ESC by IamPete1 · Pull Request #27672 · ArduPilot/ardupilot · GitHub

  • Dronecan escs don’t provide cumulative mah
  • Do the integration for them
  • Merged!

UTC0059 - AP_BattMonitor: Sum: report average temperature by IamPete1 · Pull Request #27674 · ArduPilot/ardupilot · GitHub

  • Report average temperature from Sum
  • Merged!

UTC0101 - AP_TemperatureSensor: add logging option to only log sensors with no source by IamPete1 · Pull Request #27675 · ArduPilot/ardupilot · GitHub

  • Add logging option to only log sensors with no source
  • Currently we double-log battery temperatures
  • Is double-logging really a bug problem?
  • Don’t want an option, really
  • merged!

UTC0107 - Plane update

  • Very little activity happening in beta testing threads
  • Beta2 is out
  • No announcement yet for Plane
    • Randy announced for others
  • CubeRed is only difference

UTC0108 - Copter/Rover update

  • Japan away for the next couple of days
  • Release in the next few days

UTC0110 - conference update

  • Slightly more expensive
    • Translators are going to be available
  • Talks in Japanese?
  • Shuttle bus won’t take everyone
  • Will probably be catered
  • Dietary requirements
    • Don’t rely on people telling you dietary requirements
      • Add vegetarian options even if nobody tells you
  • 900 is not going to happen in
  • Receipts for reimbursements, please!

UTC0124 - George

  • Tridge has had a couple-of-hour call with them
    • Tridge needs to follow up with them

UTC0134 - close