Dev Call Feb 19, 2024

Issues & Pull requests

Plane

Copter & Rover

Attendee count (max): 19

UTC1100 - common.xml: add a command to deal with safety switch by peterbarker · Pull Request #352 · ArduPilot/mavlink · GitHub

  • Add a command to deal with safety switch protocol
  • All vehicles have a safety switch
  • What do we do if you don’t have one?
    • Going to be unsupported
  • We’re happy, let’s get Hamish to sign off on it

UTC1105 - GCS_MAVLink: Remove wrong usage of COMMAND_ACK message by patrickelectric · Pull Request #14452 · ArduPilot/ardupilot · GitHub

  • Remove wrong usage of COMMAND_ACK for a message
  • Old one
  • Merged!
  • Set_mode the message will no longer ack in ArduPilot!

UTC1108 - AP_NavEKF3: define Yaw alignment min GPS speed per vehicle by rmackay9 · Pull Request #24206 · ArduPilot/ardupilot · GitHub

  • Define yaw alignment min gps speed per vehicle
  • Testing needed
  • Plane is unchanged

UTC1110 - Global: Replace with GCS_SEND_TEXT by muramura · Pull Request #25262 · ArduPilot/ardupilot · GitHub

  • Replace with GCS_SEND_TEXT
  • Needs a rebase

UTC1111 - Filtering: re-work harmonic notch filter freq clamping and disable by tridge · Pull Request #25442 · ArduPilot/ardupilot · GitHub

  • Re-work harmonic notch filter freq clamping
  • Logging has been added
    • FCN
    • Filter centre frequency
  • Want a second PR to see what happens with 2D logging
  • PH to look at the new logging

UTC Reduce memory used by DDS client by srmainwaring · Pull Request #26095 · ArduPilot/ardupilot · GitHub

UTC1118 - hwdef: Add AP_HW_JHEMCUGF16F405 board config by alex-pokydin · Pull Request #25620 · ArduPilot/ardupilot · GitHub

  • Commit messages need fixing
  • Adds a new JHEMCU board
  • Review left

UTC1121 - Reduce memory used by DDS client by srmainwaring · Pull Request #26095 · ArduPilot/ardupilot · GitHub

  • Reduce memory used by DDS client
  • Static arrays were silly
  • DDS not really usable in 4.5 due to out-of-memory
    • Probably backport because of this
  • Some drive-by stuff?

UTC1124 - AP_JSON: added JSON parsing library by tridge · Pull Request #26114 · ArduPilot/ardupilot · GitHub

  • Added JSON parsing library
  • Based on picojson
  • Will allow use of this in SITL
    • We fail to link of we throw any exceptions
  • Some shenanigans around examples
  • Drive-by on filesystem
    • Thread-safety
  • The fact we still have abort() in our code is problematic
    • part of “newlib”
    • Almost certainly can’t cross it
      • … well, past these patches to not use gmtime
  • New lua abort function which does nothing rather than dying
    • Except in SITL
  • This currently actively prevents using library functions that can raise exceptions
    • On ChibiOS
  • If you put a std::array in a class and you don’t initialise it, does it go in flash or BSS?
    • On the stack how is it initialised
    • Need an absolutely trivial example of std::array
      • Does offer some compile-time stuff
      • Run-time arrays bounds checking?
      • –enable-exceptions on stm32 too?
    • Need some confidence before
  • Could the compiler in-line an abort?!

UTC1144 - Copter: Excluded target velocity from slowdown calculations in FOLLOW mode by Georacer · Pull Request #26142 · ArduPilot/ardupilot · GitHub

  • Exclude target velocity from slow-down calculations
    • For follow
  • Tridge will test and merge if good

UTC1148 - AP_ROMFS: remove requirement that returned buffer is null-terminated by tpwrules · Pull Request #26184 · ArduPilot/ardupilot · GitHub

  • Remove requirement that returned buffer is null-terminated
  • Should treat these things as buffers not strings, but null-terminate them anyway in case we screw up
  • There’s a function which loads a blob into memory and returns a pointer to it
    • Load_file
    • This should also be adding a byte
    • Thomas will add

UTC0001 - adding IMU data in AP_DDS library for high frequency raw imu data transmission by Astik-2002 · Pull Request #26187 · ArduPilot/ardupilot · GitHub

  • Add IMU data in AP_DDS library for high-freq raw imu data
  • “High rate”?
    • 3 3x3 covariance matrices
      • 216 bytes!
      • … which are zeroed
  • When Ryan’s back we can discuss

UTC0003 - AP_Scripting: ensure that all pass by reference values are initialized by IamPete1 · Pull Request #26222 · ArduPilot/ardupilot · GitHub

  • Ensure all pass-by-reference values are initialised
  • merged!

UTC0005 - Rover/Copter update

  • Couple of new items from 4.5 testing
  • Pixhawk6C or 6X compasses disappearing?
    • This isn’t necessarily related to 4.5
    • Appearing for a second and then disappearing?
      • External compasses only?
  • Some problems with viewpro API
  • Tuning vertical position controller?
    • Leonard will have a read and think.
  • Camera gimbal page in MP is becoming problematic
  • Insufficient testing?
    • If you test, please report so we can have confidence the thing is tested

UTC0016 - Plane 4.5.x issue tracking · Issue #26202 · ArduPilot/ardupilot · GitHub

  • Centre-throttle problems in Plane
    • Probably MissionPlanner issue
    • Tridge opened a PR to fix a comment
    • Would be nice to make sprung throttle easier to use
      • Tickbox for “I have a sprung throttle”?
  • Ramping of motors on tilt quadplane….
    • Later in call…

UTC0023 - adding IMU data in AP_DDS library for high frequency raw imu data transmission by Astik-2002 · Pull Request #26187 · ArduPilot/ardupilot · GitHub

  • IMU data redux
  • Only useful in certain situations
  • Researcher wants this
  • The covariance matrices?
    • Known issue
    • ROS working group on message standards
      • Ryan’s working with them to make them friendlier
    • Could we make our own message?
    • DDS is supposed to make for a common standard
    • Prosima
  • #ifdefs
    • Would be good
    • We are going to run out of flash
    • Ryan wants this stuff on the custom build server

UTC0030 - https://github.com/ArduPilot/ardupilot/pull/26223m

  • Allow set_throttle in manual and move disarmed override up
  • Plane cleanup
  • Merged!

UTC0035 - AP_DroneCAN: DNA Server: log duplicate nodes in CAND by IamPete1 · Pull Request #26224 · ArduPilot/ardupilot · GitHub

  • Make it possible to work out what is clashing when you can can node id collisions
  • Can we detect on different buses?
    • Needs testing
    • Multicast
    • Measure then cut, but possible real bug

UTC0040 - AP_ROMFS: dir_list no longer looks in subfolders by IamPete1 · Pull Request #26225 · ArduPilot/ardupilot · GitHub

  • Dir_list no longer works recursively
    • I.e. only get scripts from top directory, not subfolders

UTC0046 - AC_Fence: ensure fencepoint protocol not compiled in if not HAL_GCS_ENABLED by peterbarker · Pull Request #26235 · ArduPilot/ardupilot · GitHub

  • Remove fence point protocol if no GCS
  • Merged!

UTC0047 - AC_Fence: ensure fencepoint protocol not compiled in if not HAL_GCS_ENABLED by peterbarker · Pull Request #26235 · ArduPilot/ardupilot · GitHub

  • Fix customcontroller defines
  • Merged!

UTC0048 - Copter: Autotune performance and safety enhancements by lthall · Pull Request #26245 · ArduPilot/ardupilot · GitHub

  • Improve autotune performance and safety enhancements
  • In response to lots of complaints, Leonard’s come back to do a cleanup in autotune
  • Standards dropped off and autotune stopped working so well
  • Changed twitch to follow achieved
    • Desync protection
    • Desync only ever seemed to happen when switching back to original gains to level vehicle
  • Should be an improvement on larger aircraft
  • Tridge is realflight-testing
  • Hexa-in-loiter could not bring to level
    • Repositioning code?
  • Removes multiple twitches to one side
  • Testing in RealFlight would be good.
  • May be more failures
    • Need good manual tune
    • fewer bad autotune results

UTC0011 - Plane: fixed ramp of motors on back transition in tilt quadplanes by tridge · Pull Request #26249 · ArduPilot/ardupilot · GitHub

  • No ramp on tilt-quadplane rear rotors
  • This fix looks too simple.
    • But works in all testing so far
  • More testing needed

UTC0018 - SITL: SIM_Motor: include momentum drag in derived torque by IamPete1 · Pull Request #26255 · ArduPilot/ardupilot · GitHub

  • Include momentum drag in derived torque
  • Merged!

UTC0022 - Add detected message when GPS found by peterbarker · Pull Request #26257 · ArduPilot/ardupilot · GitHub

  • Clarify messaging around GPS detection
  • Change to use a boolean on first message rather than being clever
    • Can be merged after that

UTC0027 - AC_AttitudeControl: ensure yaw gets a FLTD default by andyp1per · Pull Request #26263 · ArduPilot/ardupilot · GitHub

  • Ensure yaw gets flyd default
  • Peter Hall has some concerns
    • Maybe confusion over variable naming?
    • Need to fix the define names
  • Tilt-quadplanes?
    • Need this, irresponsible not to have
  • This is probably good, but needs better defines names

UTC0031 - Nuke macOS warnings by andyp1per · Pull Request #26264 · ArduPilot/ardupilot · GitHub

  • GSoF vs Trimble?
  • Some minor questions to answer

UTC0033 - mavproxy release requested

  • Tridge will do a pymavlink and MAVProxy release

UTC0034 - interlink controller with MAVProxy?

  • Tridge has done it
  • Will work with Henry to get things working

UTC0037 - close