It looks good but it now has conflicts.
Peter rebased it.
MergeOnCIPass.
UTC0708
This needs a Copter maintainer to merge it.
UTC0709
This needs a Copter maintainer to merge it.
Would be nice to have a separate error rate getter.
It’s a bit unclear what the error rate refers to. Not that this is PR is to blame for this.
UTC0716
Needs a Plane maintainer to merge it.
UTC0716
Would be nice for Randy to have a look.
UTC0718
Peter: This is a discontinuity in value behaviour, but it’s according to documentation. George: I find this behaviour actually intuitive.
Merged!
UTC0721
We’d need Randy to pitch in.
UTC0722
Andy: Let’s make sure that we remember this change, when we back-port boards. Peter: Left a note in the 4.6 Issues List.
Bumped for the next Dev Call.
UTC0732
Andy: I2C is quite slow, so when sharing DMA with the SD card, there’s the danger of failure to write in time.
But I’m okay with merging it, it’s specific to that vendor.
Merged!
UTC0734
We’ll need Sid to weigh in on this.
UTC0742
Andy: This is tested working. Peter: Is the scale factor correct? Andy: Haven’t checked.
I’ll make the changes then split this PR into two, one for the driver and one for the new board.
Peter: The PX4-2 connector description doesn’t match the silkscreen. Same for UART4.
The board_type ID is alrady taken.
Boards with 1M flash or less might not want this driver baked-in.
UTC0757
Amilcar: I can no longer access the parameter server, so I can’t test this anymore.
Perhaps my IP address changed and I can’t rsync in anymore.
This PR will allow GCSs (i.e. Mission Planner) to get the stable parameter .xml list, not the one from master.
I would like that we upload parameter descriptions for each patch release.
Peter: It would be nice if we uploaded them next to the board binaries. Amilcar: I had suggested the same, but tridge wanted them in a separate, dedicated directory. Peter: We could also be pointing the GCS to the correct parameter file in the manifest.json.
In any case, if you can set it up to push the parameter metadata next to the binaries, I’ll advocate for it.
I’ll go and refactor param_parse.py into a importable module.